vm: implement case string in bytecode
#1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a sequence of `EqStr` + `opcTJmp` pairs for implementing `case` statements with a selector of type string. This is less efficient (especially due to `LdConst` still creating a copy) and increases code size, but it removes a user of "simple" string constants (which are going to be removed eventually).
It's obsolete now that a manual comparison chain is used.
It's not used anywhere anymore.
zerbina
added
compiler/vm
saem
approved these changes
Jan 30, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the dedicated
stringslice-list matching support from the VMand replace it with an in-bytecode implementation. This gives more
control to the code generator and removes the last internal usage of
cnstString, preparing for the latter's removal.Details
An
ofbranch of acasematching over a string is now translatedinto a sequence of
LdConst+EqStr+TJmp(one per label),replicating the behaviour previously implemented by the
Branchopcode.
While the bytecode implementation is a bit slower and also results in
slightly larger VM executables, having less high-level string operations
in the VM makes it easier to evolve.
The string slice-list matching is removed from the
Branchopcodeimplementation, and
cnstSliceListStrtogether with all its usages isremoved.